[node-patches] Change in ovirt-node[master]: Add config keys to exchange management infos

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Add config keys to exchange management infos
......................................................................


Patch Set 3:

(5 comments)

....................................................
File src/ovirt/node/setup/core/status_page.py
Line 104: 
Line 105:                     ui.Row("row[0]", network_widgets),
Line 106:                     ui.Divider("divider[1]"),
Line 107: 
Line 108:                     ui.KeywordLabel("logs", aligned(_("Logs: "))),
do we need those _ ?
Line 109:                     ui.Divider("divider[2]"),
Line 110: 
Line 111:                     ui.KeywordLabel("libvirt.num_guests",
Line 112:                                     aligned(_("Running VMs: "))),


Line 108:                     ui.KeywordLabel("logs", aligned(_("Logs: "))),
Line 109:                     ui.Divider("divider[2]"),
Line 110: 
Line 111:                     ui.KeywordLabel("libvirt.num_guests",
Line 112:                                     aligned(_("Running VMs: "))),
_ here
Line 113:                     ui.Divider("divider[3]"),
Line 114: 
Line 115:                     ui.Label("support.hint", _("Press F8 for support menu")),
Line 116:                     ui.Divider("divider[4]"),


Line 111:                     ui.KeywordLabel("libvirt.num_guests",
Line 112:                                     aligned(_("Running VMs: "))),
Line 113:                     ui.Divider("divider[3]"),
Line 114: 
Line 115:                     ui.Label("support.hint", _("Press F8 for support menu")),
here too
Line 116:                     ui.Divider("divider[4]"),
Line 117: 
Line 118:                     ui.Row("row[1]",
Line 119:                            [ui.Button("action.hostkey", _("View Host Key")),


Line 115:                     ui.Label("support.hint", _("Press F8 for support menu")),
Line 116:                     ui.Divider("divider[4]"),
Line 117: 
Line 118:                     ui.Row("row[1]",
Line 119:                            [ui.Button("action.hostkey", _("View Host Key")),
too
Line 120:                             ui.Button("action.cpu_details",
Line 121:                                       _("View CPU Details")),
Line 122:                             ]),
Line 123: 


Line 117: 
Line 118:                     ui.Row("row[1]",
Line 119:                            [ui.Button("action.hostkey", _("View Host Key")),
Line 120:                             ui.Button("action.cpu_details",
Line 121:                                       _("View CPU Details")),
here
Line 122:                             ]),
Line 123: 
Line 124:                     ui.Row("row[2]", action_widgets),
Line 125:                     ]


-- 
To view, visit http://gerrit.ovirt.org/22374
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855f03559c4e47ab2a71726849425db0ef2d5a6a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes