[node-patches] Change in ovirt-node[master]: Validate "Other Device" against live device

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Jan 29 08:17:32 UTC 2014


Fabian Deutsch has submitted this change and it was merged.

Change subject: Validate "Other Device" against live device
......................................................................


Validate "Other Device" against live device

Previously, we didn't check whether or not "Other Device" input
matched against a known live device or not (USB boot, etc). Do so.
As part of this, slight rearrangement of storage.Device to improve
responsiveness when looking for udev devices (we're assuming udev
will not change during the install), and get the new validation
workflow to properly invalid pages if a plugin's on_change throws
an exception.

Change-Id: I44b87876876965418765cbb6a0c0030bf143f156
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=885017
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/installer/core/boot_device_page.py
M src/ovirt/node/installer/core/installation_device_page.py
2 files changed, 19 insertions(+), 8 deletions(-)



-- 
To view, visit http://gerrit.ovirt.org/19879
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I44b87876876965418765cbb6a0c0030bf143f156
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the node-patches mailing list