[node-patches] Change in ovirt-node[master]: pythonize scripts/persist and make it use Config.persist

dougsland at redhat.com dougsland at redhat.com
Wed Jul 2 17:04:47 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: pythonize scripts/persist and make it use Config.persist
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/29056/5/scripts/persist
File scripts/persist:

Line 1: #!/usr/bin/env python2
Please correct me if I am wrong but this file don't have any specific python2 requirement. I know that /src/ovirt/node/utils/fs.py has isn't better to have such "python2" there instead of? Other than that, +1
Line 2: #
Line 3: # Copyright (C) 2014, Red Hat, Inc.
Line 4: # Written by Antoni Segura Puimedon <asegurap at redhat.com>
Line 5: #


-- 
To view, visit http://gerrit.ovirt.org/29056
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I118f981ef1b1f1b663a176a4e64850ad97248497
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list