[node-patches] Change in ovirt-node[master]: make src/ovirt/node/ package use the new Config.persist

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: make src/ovirt/node/ package use the new Config.persist
......................................................................


Patch Set 5: Code-Review-1

(4 comments)

I have question -1, no alarms.

http://gerrit.ovirt.org/#/c/29055/5/src/ovirt/node/config/defaults.py
File src/ovirt/node/config/defaults.py:

Line 1143:                     for confpath in ("/root/.ssh/kdump_id_rsa.pub",
Line 1144:                                      "/root/.ssh/kdump_id_rsa",
Line 1145:                                      "/root/.ssh/known_hosts",
Line 1146:                                      "/root/.ssh/config"):
Line 1147:                         conf.persist(confpath)
How bad is it if we use directly Config().persist(confpath) ?
Line 1148:                 except utils.process.CalledProcessError as e:
Line 1149:                     self.logger.warning("Failed to activate KDump with " +
Line 1150:                                         "SSH: %s" % e)
Line 1151: 


Line 1444:                 kbd = utils.system.Keyboard()
Line 1445:                 kbd.set_layout(layout)
Line 1446:                 conf = Config()
Line 1447:                 conf.persist("/etc/vconsole.conf")
Line 1448:                 conf.persist("/etc/sysconfig/keyboard")
How bad is it if we use directly Config().persist(my_file) ?
Line 1449: 
Line 1450:         tx = utils.Transaction("Configuring keyboard layout")
Line 1451:         tx.append(CreateKeyboardConfig())
Line 1452:         return tx


http://gerrit.ovirt.org/#/c/29055/5/src/ovirt/node/setup/rhn/rhn_model.py
File src/ovirt/node/setup/rhn/rhn_model.py:

Line 185:                 try:
Line 186:                     subprocess.check_call(args)
Line 187:                     conf = Config()
Line 188:                     conf.persist("/etc/sysconfig/rhn/up2date")
Line 189:                     conf.persist("/etc/sysconfig/rhn/systemid")
how bad is it if we use directly Config().persist(my_file)?
Line 190:                     self.logger.info("System %s sucessfully registered to %s" %
Line 191:                                      (profilename, serverurl))
Line 192:                     # sync profile if reregistering, fixes problem with
Line 193:                     # virt guests not showing


Line 349:                     conf = Config()
Line 350:                     conf.persist(rhsm_configs)
Line 351:                     conf.persist("/etc/pki/consumer/key.pem")
Line 352:                     conf.persist("/etc/pki/consumer/cert.pem")
Line 353:                     self.logger.info("System %s sucessfully registered \
how bad is it if we use directly Config().persist(my_file)?
Line 354:                                       to %s" % (profilename, serverurl))
Line 355: 
Line 356:         cfg = self.retrieve()
Line 357:         self.logger.debug(cfg)


-- 
To view, visit http://gerrit.ovirt.org/29055
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b153524496e278e97cb7e0a6f88392d5aad26ba
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes