[node-patches] Change in ovirt-node[master]: mount_config: Add support for symbolic links

fabiand at fedoraproject.org fabiand at fedoraproject.org
Thu Jul 3 16:00:58 UTC 2014


Fabian Deutsch has submitted this change and it was merged.

Change subject: mount_config: Add support for symbolic links
......................................................................


mount_config: Add support for symbolic links

Up until now, symbolic links used to be treated like regular files
(just as directories were before the preceding patch of the branch).
This meant that trying to restore a persisted symlink would try to
bind mount whatever the symbolic link was pointing at originally.
However, some application might rely on a symbolic link being a
symbolic link and not whatever that symbolic link was pointing at.

With this patch, if we persisted a symbolic link as:

    /config/files:
        /absolute/path/to/the/symbolic/link

    /config/absolute/path/to/the/symbolic/link linking to:
        /absolute/path/to/target/of/symbolic/link

we'll get

    /absolute/path/to/the/symbolic/link linking to:
        /absolute/path/to/target/of/symbolic/link

Once the persist is fixed for symbolic links, it will behave like
file persistence does now, you should call persist after changes
to the link.

Change-Id: I8e009e3039b2df80d57e60460d6cc888a91f7577
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
---
M scripts/ovirt-functions.in
1 file changed, 11 insertions(+), 5 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve
  Antoni Segura Puimedon: Verified
  Ryan Barry: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/29011
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e009e3039b2df80d57e60460d6cc888a91f7577
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the node-patches mailing list