[node-patches] Change in ovirt-node[master]: Fixups to silence check-local
fabiand at fedoraproject.org
fabiand at fedoraproject.org
Thu Jul 3 16:00:59 UTC 2014
Fabian Deutsch has uploaded a new change for review.
Change subject: Fixups to silence check-local
......................................................................
Fixups to silence check-local
Change-Id: I978f50205eea9bd93799a5046515238502a34e1c
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/installer/core/progress_page.py
M src/ovirt/node/utils/fs/__init__.py
2 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/64/29564/1
diff --git a/src/ovirt/node/installer/core/progress_page.py b/src/ovirt/node/installer/core/progress_page.py
index f9b658e..05e4869 100644
--- a/src/ovirt/node/installer/core/progress_page.py
+++ b/src/ovirt/node/installer/core/progress_page.py
@@ -188,7 +188,7 @@
app = self.progress_plugin.application
config = {}
for pname, plugin in app.plugins().items():
- if not "Confirm disk selections" in pname:
+ if "Confirm disk selections" not in pname:
self.logger.debug("Config for page %s" % (pname))
try:
model = plugin.model()
diff --git a/src/ovirt/node/utils/fs/__init__.py b/src/ovirt/node/utils/fs/__init__.py
index fc09289..97fcbf0 100644
--- a/src/ovirt/node/utils/fs/__init__.py
+++ b/src/ovirt/node/utils/fs/__init__.py
@@ -373,13 +373,9 @@
Returns:
True if the file is a bind mount target
"""
- bind_mount_found = False
mounts = File("/proc/mounts")
pattern = "%s %s" % (filename, fsprefix)
- for mount in mounts:
- if pattern in mount:
- bind_mount_found = True
- return bind_mount_found
+ return any(pattern in mountp for mountp in mounts)
class Config(base.Base):
--
To view, visit http://gerrit.ovirt.org/29564
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I978f50205eea9bd93799a5046515238502a34e1c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
More information about the node-patches
mailing list