[node-patches] Change in ovirt-node[master]: Fix value error during configuring installation.device.custo...

hadong0720 at gmail.com hadong0720 at gmail.com
Mon Jul 7 05:29:42 UTC 2014


hadong has uploaded a new change for review.

Change subject: Fix value error during configuring installation.device.custom into "/dev/sda,/dev/sdb".
......................................................................

Fix value error during configuring installation.device.custom into "/dev/sda,/dev/sdb".

Change-Id: I4a98405dfe27445d17b002e744a8ca2e50660174
Signed-off-by: hadong <hadong at redhat.com>
---
M src/ovirt/node/installer/core/installation_device_page.py
1 file changed, 3 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/22/29622/1

diff --git a/src/ovirt/node/installer/core/installation_device_page.py b/src/ovirt/node/installer/core/installation_device_page.py
index 9cfb726..b629d17 100644
--- a/src/ovirt/node/installer/core/installation_device_page.py
+++ b/src/ovirt/node/installer/core/installation_device_page.py
@@ -170,15 +170,12 @@
         elif changes.contains_any(["installation.device.custom",
                                    "dialog.device.custom.save"]):
             self._dialog.close()
-            cdev = self._model["installation.device.custom"]
-            self._model["installation.devices"].append(cdev)
+            m = self._model
+            cdevs = m["installation.device.custom"].split(",")
+            m.setdefault("installation.devices", []).extend(cdevs)
             self.application.ui.navigate.to_next_plugin()
 
         if changes.contains_any(["button.back"]):
             self.application.ui.navigate.to_previous_plugin()
         elif changes.contains_any(["button.next"]):
-            if "installation.device.custom" in self._model:
-                m = self._model
-                cdevs = m["installation.device.custom"].split(",")
-                m.setdefault("installation.devices", []).extend(cdevs)
             self.application.ui.navigate.to_next_plugin()


-- 
To view, visit http://gerrit.ovirt.org/29622
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a98405dfe27445d17b002e744a8ca2e50660174
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>



More information about the node-patches mailing list