[node-patches] Change in ovirt-node[master]: Add validator for ssh port to only accpet "22" or "1024-65535"

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Add validator for ssh port to only accpet "22" or "1024-65535"
......................................................................


Patch Set 1:

(3 comments)

minor comments, please take a look.

http://gerrit.ovirt.org/#/c/29957/1/src/ovirt/node/utils/security.py
File src/ovirt/node/utils/security.py:

Line 191
Line 192
Line 193
Line 194
Line 195
shouldn't be 1024-65535 ? What about to have a _constant to avoid duplicating this value below?


Line 197
Line 198
Line 199
Line 200
Line 201
shouldn't be 1024-65535 ?


Line 200
Line 201
Line 202
Line 203
Line 204
shouldn't be 1024-65535 ?


-- 
To view, visit http://gerrit.ovirt.org/29957
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5fe06ad0a1c8345e3b1265cbafdabc275bf1b5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes