[node-patches] Change in ovirt-node[master]: disable continue button if Free space was negative

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: disable continue button if Free space was negative
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

I have a virtual machine with no partition and I couldn't install it as in the past.

http://gerrit.ovirt.org/#/c/27955/4/src/ovirt/node/installer/core/storage_vol_page.py
File src/ovirt/node/installer/core/storage_vol_page.py:

Line 107:             if self.model() and self.__calculate_free_space() < 0:
Line 108:                 page.buttons.extend([ui.SaveButton("button.next",
Line 109:                                                    _("Continue"),
Line 110:                                                    enabled=False)])
Line 111:             else:
else not aligned with the first if, so users won't be able continue. You could keep using the positive sentece as well i self.__enough_free_space(): ... else: ...
Line 112:                 page.buttons.extend([ui.SaveButton("button.next",
Line 113:                                                    _("Continue"))])
Line 114: 
Line 115:         return page


Line 227:         return free_space
Line 228: 
Line 229:     def __enough_free_space(self):
Line 230:         """Determin if the available size is large enough to hold the
Line 231:            installation
Not related to the patch. I have sent a patch specific to this pep8 complain here: http://gerrit.ovirt.org/#/c/30050/
Line 232:         """
Line 233:         self._drive_size = self.__get_drives_size(self.__get_install_drive())


-- 
To view, visit http://gerrit.ovirt.org/27955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f8dcfa7b980b5b272fc5845b3f228af7fe4f21e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes