[node-patches] Change in ovirt-node[master]: Fix value error during configuring installation.device.custo...

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Fix value error during configuring installation.device.custom into "/dev/sda,/dev/sdb".
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.ovirt.org/#/c/29622/2//COMMIT_MSG
Commit Message:

Line 4: Commit:     hadong <hadong at redhat.com>
Line 5: CommitDate: 2014-07-15 12:09:25 +0800
Line 6: 
Line 7: Fix value error during configuring installation.device.custom into "/dev/sda,/dev/sdb".
Line 8: 
Hi, do we have a bugzilla for this one? Is there any clear reproducer steps?
Line 9: Change-Id: I4a98405dfe27445d17b002e744a8ca2e50660174


http://gerrit.ovirt.org/#/c/29622/2/src/ovirt/node/installer/core/installation_device_page.py
File src/ovirt/node/installer/core/installation_device_page.py:

Line 170:         elif changes.contains_any(["installation.device.custom",
Line 171:                                    "dialog.device.custom.save"]):
Line 172:             self._dialog.close()
Line 173:             m = self._model
Line 174:             cdevs = m.get("installation.device.custom", "").split(",") or []
is it possible to do self._model.get("..") ?
Line 175:             m.setdefault("installation.devices", []).extend(cdevs)
Line 176:             self.application.ui.navigate.to_next_plugin()
Line 177: 
Line 178:         if changes.contains_any(["button.back"]):


Line 171:                                    "dialog.device.custom.save"]):
Line 172:             self._dialog.close()
Line 173:             m = self._model
Line 174:             cdevs = m.get("installation.device.custom", "").split(",") or []
Line 175:             m.setdefault("installation.devices", []).extend(cdevs)
is it possible to do self._model.setdefault(..) ?
Line 176:             self.application.ui.navigate.to_next_plugin()
Line 177: 
Line 178:         if changes.contains_any(["button.back"]):
Line 179:             self.application.ui.navigate.to_previous_plugin()


-- 
To view, visit http://gerrit.ovirt.org/29622
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a98405dfe27445d17b002e744a8ca2e50660174
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes