[node-patches] Change in ovirt-node[master]: Add a confirmation dialog if rhn.url or rhn.ca are blank

fabiand at redhat.com fabiand at redhat.com
Fri Jul 18 15:48:47 UTC 2014


Hello Ryan Barry,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/30419

to review the following change.

Change subject: Add a confirmation dialog if rhn.url or rhn.ca are blank
......................................................................

Add a confirmation dialog if rhn.url or rhn.ca are blank

Same old validation problem -- we can't validate that a field is
empty unless the user bothers to type something into it. Check
whether something was entered in on_merge instead and pop up a
dialog if it was not. Additionally, clean up rhn_page a bit to
meet Python standards.

Change-Id: I5256ada34e12dea52a5f0ae5609034c3e0a80a4e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1022508
Signed-off-by: Ryan Barry <rbarry at redhat.com>
Signed-off-by: Fabian Deutsch <fabiand at redhat.com>
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/19/30419/1



-- 
To view, visit http://gerrit.ovirt.org/30419
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5256ada34e12dea52a5f0ae5609034c3e0a80a4e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>



More information about the node-patches mailing list