[node-patches] Change in ovirt-node[master]: Always use local kdump after install installs

[rbarry at redhat.com]

Ryan Barry has uploaded a new change for review.

Change subject: Always use local kdump after install installs
......................................................................

Always use local kdump after install installs

If no kdump parameters are specified, default to local. Instead
of leaving the service disabled

Change-Id: I5dcf8a8046a8c4284edf0bd3ed6ed24000ffe7ef
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1123413
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122917
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M scripts/ovirt-auto-install.py
M src/ovirt/node/installer/core/progress_page.py
2 files changed, 19 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/05/30705/1

diff --git a/scripts/ovirt-auto-install.py b/scripts/ovirt-auto-install.py
index 8d9b5c5..bc717d4 100755
--- a/scripts/ovirt-auto-install.py
+++ b/scripts/ovirt-auto-install.py
@@ -178,7 +178,7 @@
                                     OVIRT_VARS["OVIRT_KDUMP_SSH_KEY"])
             elif "OVIRT_KDUMP_NFS" in OVIRT_VARS:
                 model.configure_nfs(OVIRT_VARS["OVIRT_KDUMP_NFS"])
-            elif "OVIRT_KDUMP_LOCAL" in OVIRT_VARS:
+            else:
                 model.configure_local()
 
             tx = model.transaction()
diff --git a/src/ovirt/node/installer/core/progress_page.py b/src/ovirt/node/installer/core/progress_page.py
index 347e22e..008daa0 100644
--- a/src/ovirt/node/installer/core/progress_page.py
+++ b/src/ovirt/node/installer/core/progress_page.py
@@ -166,7 +166,8 @@
                    self.PartitionAndFormat(cfg["installation.devices"]),
                    self.SetPassword(cfg["admin.password"]),
                    self.InstallImageAndBootloader(cfg["boot.device.current"]),
-                   self.SetKeyboardLayout(cfg["keyboard.layout"])]
+                   self.SetKeyboardLayout(cfg["keyboard.layout"]),
+                   self.ConfigureKdump()]
 
             if system.is_pxe():
                     tx += [self.ClearNetworkConfig()]
@@ -297,6 +298,22 @@
             tx = model.transaction()
             tx()
 
+    class ConfigureKdump(Transaction.Element):
+        title = "Configuring Local KDump"
+
+        def __init__(self):
+            super(InstallerThread.ConfigureKdump, self).__init__()
+
+        def commit(self):
+            try:
+                model = defaults.KDump()
+                model.configure_local()
+                tx = model.transaction()
+                tx()
+
+            except:
+                logger.warning("Could not configure local kdump!")
+
     class MigrateConfigs(utils.Transaction.Element):
         title = "Migrating configuration data"
 


-- 
To view, visit http://gerrit.ovirt.org/30705
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5dcf8a8046a8c4284edf0bd3ed6ed24000ffe7ef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>