[node-patches] Change in ovirt-node[master]: Add a on-boot hook to run scripts on boot

dougsland at redhat.com dougsland at redhat.com
Thu Jun 19 22:44:29 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: Add a on-boot hook to run scripts on boot
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

http://gerrit.ovirt.org/#/c/28953/1/scripts/ovirt-init-functions.sh.in
File scripts/ovirt-init-functions.sh.in:

Line 1009:     if [[ -d "$HOOK_ON_BOOT_DIR" ]];
Line 1010:     then
Line 1011:         for script in "$HOOK_ON_BOOT_DIR"/*;
Line 1012:         do
Line 1013:             handler="$HOOK_ON_BOOT_DIR"/"$script"
handler patch is duplicated in this case.
Line 1014:             echo "Running handler: $handler"
Line 1015:             "$handler"
Line 1016:         done
Line 1017:     fi


Line 1010:     then
Line 1011:         for script in "$HOOK_ON_BOOT_DIR"/*;
Line 1012:         do
Line 1013:             handler="$HOOK_ON_BOOT_DIR"/"$script"
Line 1014:             echo "Running handler: $handler"
$script or attach the $script to $handler in the top.
Line 1015:             "$handler"
Line 1016:         done
Line 1017:     fi
Line 1018: 


Line 1011:         for script in "$HOOK_ON_BOOT_DIR"/*;
Line 1012:         do
Line 1013:             handler="$HOOK_ON_BOOT_DIR"/"$script"
Line 1014:             echo "Running handler: $handler"
Line 1015:             "$handler"
$script or attach the $script to $handler in the top.
Line 1016:         done
Line 1017:     fi
Line 1018: 
Line 1019:     return 0


-- 
To view, visit http://gerrit.ovirt.org/28953
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I306c1f12da7ec3e2454a8504cd3c462364a291f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list