[node-patches] Change in ovirt-node[master]: build: Rework build/naming process

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: build: Rework build/naming process
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.ovirt.org/#/c/29404/1/Makefile.am
File Makefile.am:

Line 59: RELEASE_SUFFIX ?=
Line 60: srpm:	dist
Line 61: 	rm -fr "$(TMPREPOS)"
Line 62: 	mkdir -p $(TMPREPOS)/{SPECS,RPMS,SRPMS,SOURCES}
Line 63: 	$(RPMBUILD) --define="_topdir `pwd`/$(TMPREPOS)" --define="release_suffix $$RELEASE_SUFFIX" -ts "$(PACKAGE_TARNAME)-$(PACKAGE_VERSION).tar.gz"
> you should not force using the release suffix.
that is why I basically leave it undefined. But I will change the logic to not even pass it if not used
Line 64: 	@echo
Line 65: 	@echo "srpm available at '$(TMPREPOS)'"
Line 66: 	@echo
Line 67: 


http://gerrit.ovirt.org/#/c/29404/1/ovirt-node.spec.in
File ovirt-node.spec.in:

Line 27: Summary:        The %{product_family} daemons/scripts
Line 28: Name:           ovirt-node
Line 29: Version:        @PACKAGE_RPM_VERSION@
Line 30: Release:        @PACKAGE_RPM_RELEASE@%{?release_suffix}%{?dist}
Line 31: Source0:        http://plain.resources.ovirt.org/pub/ovirt-master-snapshot/src/%{name}/%{name}-%{package_version}.tar.gz
> you will need to change it on each release :)
I think best practice here is to use the correct link (with the correct version)
Line 32: License:        GPLv2+
Line 33: Group:          Applications/System
Line 34: 
Line 35: URL:            http://www.ovirt.org/


Line 406: # </minimizer subpackage>
Line 407: %endif
Line 408: 
Line 409: 
Line 410: %prep
> quotes
Quotes? What quotes? :)
Line 411: %setup -q -n %{name}-%{package_version}
Line 412: 
Line 413: 
Line 414: %build


-- 
To view, visit http://gerrit.ovirt.org/29404
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11a608719bde0bcd6cb3edb39acbfc3b0ee1fe5f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Kiril Nesenko <knesenko at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes