[node-patches] Change in ovirt-node[node-3.0]: installer: Require input on custom device dialog

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Mar 5 11:27:18 UTC 2014


Fabian Deutsch has uploaded a new change for review.

Change subject: installer: Require input on custom device dialog
......................................................................

installer: Require input on custom device dialog

Previously the user could save the custom device dialog even if he
didn't input a device path, this lead to an exception.
Now the user is required to input a valid device path before he can save
the dialog.

Change-Id: I075dd7c5643b7b8ec716166699e21f8f273e55f3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1065894
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/installer/core/boot_device_page.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/99/25399/1

diff --git a/src/ovirt/node/installer/core/boot_device_page.py b/src/ovirt/node/installer/core/boot_device_page.py
index bd3a851..e91c5b0 100644
--- a/src/ovirt/node/installer/core/boot_device_page.py
+++ b/src/ovirt/node/installer/core/boot_device_page.py
@@ -228,5 +228,7 @@
                     device_entry]
         super(CustomDeviceDialog, self).__init__("%s.dialog" % path_prefix,
                                                  title, children)
-        self.buttons = [ui.SaveButton("dialog.device.custom.save"),
-                        ui.CloseButton("dialog.device.custom.close", "Cancel")]
+        self.buttons = [ui.SaveButton("dialog.device.custom.save", "Save",
+                                      enabled=False),
+                        ui.CloseButton("dialog.device.custom.close",
+                                       "Cancel")]


-- 
To view, visit http://gerrit.ovirt.org/25399
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I075dd7c5643b7b8ec716166699e21f8f273e55f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: node-3.0
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list