[node-patches] Change in ovirt-node[master]: Add return value when persist command does not return an err...

[wenyi at linux.vnet.ibm.com]

Wenyi Gao has posted comments on this change.

Change subject: Add return value when persist command does not return an error code on failure
......................................................................


Patch Set 3:

(1 comment)

Looks good, just one code style issue.

http://gerrit.ovirt.org/#/c/22117/3/scripts/ovirt-functions.in
File scripts/ovirt-functions.in:

Line 654: ovirt_store_config_retnum("$p")
Line 655: sys.exit(0)
Line 656: EOP
Line 657:     rc=$?
Line 658:     if [ $rc -eq 1 ] || [ $rc -eq 2 ]; then
Looks better if there is one more indent before "if" against "for" case.
Line 659:         return $rc
Line 660:     fi
Line 661:     done
Line 662:     return $rc


-- 
To view, visit http://gerrit.ovirt.org/22117
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I014c41c9919cc9f8c260d85e0ef1a23ad17021a2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: zhihui li <liyuran9522 at gmail.com>
Gerrit-Reviewer: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes