[node-patches] Change in ovirt-node[master]: spec: Add minimizer subpackage

[sbonazzo at redhat.com]

Sandro Bonazzola has posted comments on this change.

Change subject: spec: Add minimizer subpackage
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

http://gerrit.ovirt.org/#/c/26144/2/ovirt-node.spec.in
File ovirt-node.spec.in:

Line 367: %endif
Line 368: 
Line 369: 
Line 370: #
Line 371: # minimizer subpackage
<minimizer subpackage >
if you're uising tag-like comments
Line 372: #
Line 373: %if {with_minimizer}
Line 374: %package minimizer
Line 375: Summary:        The image-minimizer tool


Line 369: 
Line 370: #
Line 371: # minimizer subpackage
Line 372: #
Line 373: %if {with_minimizer}
missing % causes jenkins failure
Line 374: %package minimizer
Line 375: Summary:        The image-minimizer tool
Line 376: Group:          Applications/System
Line 377: Obsoletes:      appliance-tools-minimizer


Line 373: %if {with_minimizer}
Line 374: %package minimizer
Line 375: Summary:        The image-minimizer tool
Line 376: Group:          Applications/System
Line 377: Obsoletes:      appliance-tools-minimizer
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

This should be:
	Obsoletes: appliance-tools-minimizer < $obsEVR
        Provides: appliance-tools-minimizer = $provEVR
Line 378: 
Line 379: 
Line 380: %description minimizer
Line 381: This package ships the image-minimizer tool.


-- 
To view, visit http://gerrit.ovirt.org/26144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1de0066fdc7bf5ca9c441f6a65b495eb73754c40
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes