[node-patches] Change in ovirt-node[node-3.0]: Fix typeerror "takes exactly 1 argument(2 given)" in identif...

fabiand at fedoraproject.org fabiand at fedoraproject.org
Thu Mar 27 15:08:49 UTC 2014


Hello hadong,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/26164

to review the following change.

Change subject: Fix typeerror "takes exactly 1 argument(2 given)" in identify() of BridgedNIC
......................................................................

Fix typeerror "takes exactly 1 argument(2 given)" in identify() of BridgedNIC

Change-Id: I5f6e0e9cd035862dc9a433102c07fc0fb93d6970
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067863
Signed-off-by: hadong <hadong at redhat.com>
---
M src/ovirt/node/utils/network.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/64/26164/1

diff --git a/src/ovirt/node/utils/network.py b/src/ovirt/node/utils/network.py
index 5d0d426..65c54cd 100644
--- a/src/ovirt/node/utils/network.py
+++ b/src/ovirt/node/utils/network.py
@@ -395,7 +395,7 @@
         return self.slave_nic.vlanids()
 
     def identify(self):
-        self.slave_nic.identify(self)
+        self.slave_nic.identify()
 
     def __str__(self):
         pairs = {"bridge": self.bridge_nic,


-- 
To view, visit http://gerrit.ovirt.org/26164
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f6e0e9cd035862dc9a433102c07fc0fb93d6970
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: node-3.0
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>



More information about the node-patches mailing list