[node-patches] Change in ovirt-node[master]: If booted from PXE, don't filter live devices

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: If booted from PXE, don't filter live devices
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Functional okay.

http://gerrit.ovirt.org/#/c/27308/2/src/ovirt/node/utils/storage.py
File src/ovirt/node/utils/storage.py:

Line 107:         """
Line 108:         if self._cached_live_disk_name:
Line 109:             return self._cached_live_disk_name
Line 110: 
Line 111:         from ovirt.node.utils import system
because this is from the new codebase, please import this at the top of the file
Line 112:         args = [x for x in system.kernel_cmdline_arguments().keys() if
Line 113:                 x.startswith("BOOTIF")]
Line 114:         if args:
Line 115:             # We're PXE, don't filter anything


Line 110: 
Line 111:         from ovirt.node.utils import system
Line 112:         args = [x for x in system.kernel_cmdline_arguments().keys() if
Line 113:                 x.startswith("BOOTIF")]
Line 114:         if args:
I believe you can just do:

    if "BOOTIF" in system.kernel_cmdline_arguments():

And it would be great if you could add a doctest for this to the system.kernel_cmdline_arguments method!
Line 115:             # We're PXE, don't filter anything
Line 116:             name = ""
Line 117:         else:
Line 118:             from ovirtnode.ovirtfunctions import get_live_disk


-- 
To view, visit http://gerrit.ovirt.org/27308
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38c3316fcf7d9eb06f030b8ebc5319389278eca0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes