[node-patches] Change in ovirt-node[master]: Find installer exceptions
fabiand at fedoraproject.org
fabiand at fedoraproject.org
Thu May 1 20:56:25 UTC 2014
Fabian Deutsch has posted comments on this change.
Change subject: Find installer exceptions
......................................................................
Patch Set 1:
(1 comment)
See inline
http://gerrit.ovirt.org/#/c/27303/1/src/ovirt/node/config/migrate.py
File src/ovirt/node/config/migrate.py:
Line 82: class ImportConfigs(base.Base):
Line 83: """Import the real configs into Node's abstract config
Line 84: """
Line 85: def __init__(self):
Line 86: from ovirt.node.utils import AugeasWrapper
Isn't it enough if we import only the aug stuff here, and do all ther imports at the top?
Line 87:
Line 88: self.aug = AugeasWrapper()
Line 89: super(ImportConfigs, self).__init__()
Line 90:
--
To view, visit http://gerrit.ovirt.org/27303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida10fd5ae68d2b8eececd58d154adf9d3042ff28
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the node-patches
mailing list