[node-patches] Change in ovirt-node[master]: Flag the appropriate kdump field if empty

[rbarry at redhat.com]

Ryan Barry has uploaded a new change for review.

Change subject: Flag the appropriate kdump field if empty
......................................................................

Flag the appropriate kdump field if empty

It was possible to attempt to configure kdump with an empty nfs or
ssh entry field after the appropriate checkboxes were ticked. Now,
we should remove the ability to leave it empty

Change-Id: Ib4b879204ac20938c9d760c6d63e0947251238f5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1017083
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/setup/core/kdump_page.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/36/27336/1

diff --git a/src/ovirt/node/setup/core/kdump_page.py b/src/ovirt/node/setup/core/kdump_page.py
index 3f7fff1..8fa6e30 100644
--- a/src/ovirt/node/setup/core/kdump_page.py
+++ b/src/ovirt/node/setup/core/kdump_page.py
@@ -73,10 +73,8 @@
         """
         # FIXME improve validation for ssh and nfs
         return {"kdump.type": valid.Options(dict(self._types).keys()),
-                "kdump.ssh_location": (valid.Empty() |
-                                       valid.SSHAddress(allow_ipv6=False)),
-                "kdump.nfs_location": (valid.Empty() |
-                                       valid.NFSAddress(allow_ipv6=False)),
+                "kdump.ssh_location": (valid.SSHAddress(allow_ipv6=False)),
+                "kdump.nfs_location": (valid.NFSAddress(allow_ipv6=False)),
                 }
 
     def ui_content(self):
@@ -132,11 +130,13 @@
                 if w in self.widgets:
                     self.widgets[w].enabled(False)
                     self.widgets[w].value("")
+                    self.forget_changes(w)
 
             w = "kdump.%s_location" % changes["kdump.type"]
             if w in net_types and w in self.widgets:
                 self.widgets[w].enabled(True)
                 self.widgets[w].value(self._model[w])
+                self.force_input(w)
 
     def on_merge(self, effective_changes):
         """Applies the changes to the plugins model, will do all required logic


-- 
To view, visit http://gerrit.ovirt.org/27336
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4b879204ac20938c9d760c6d63e0947251238f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>