[node-patches] Change in ovirt-node[master]: If booted from PXE, don't filter live devices

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: If booted from PXE, don't filter live devices
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/27308/3/src/ovirt/node/utils/storage.py
File src/ovirt/node/utils/storage.py:

Line 108:         """
Line 109:         if self._cached_live_disk_name:
Line 110:             return self._cached_live_disk_name
Line 111: 
Line 112:         if "BOOTIF" in system.kernel_cmdline_arguments():
Please add system.is_pxe() - to keep the logic for this in one place.
Line 113:             # We're PXE, don't filter anything
Line 114:             name = ""
Line 115:         else:
Line 116:             from ovirtnode.ovirtfunctions import get_live_disk


-- 
To view, visit http://gerrit.ovirt.org/27308
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38c3316fcf7d9eb06f030b8ebc5319389278eca0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes