[node-patches] Change in ovirt-node[master]: Fix previous commit http://gerrit.ovirt.org/#/c/25470/

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed May 7 15:01:35 UTC 2014


Fabian Deutsch has posted comments on this change.

Change subject: Fix previous commit http://gerrit.ovirt.org/#/c/25470/
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26778/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-04-15 14:03:06 +0800
Line 4: Commit:     hadong <hadong at redhat.com>
Line 5: CommitDate: 2014-04-15 14:15:04 +0800
Line 6: 
Line 7: Fix previous commit http://gerrit.ovirt.org/#/c/25470/
Please use a more descriptive first line.

i.e.: re-use install instead of update
Line 8: 
Line 9: Previous commit:http://gerrit.ovirt.org/#/c/25470/
Line 10: to add --update into edit-node to update packages.but this patch
Line 11: didn't achieve "_run_yum_update" functions


-- 
To view, visit http://gerrit.ovirt.org/26778
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I778d4255e6b0f3d76e576675356e8e11263ed935
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list