[node-patches] Change in ovirt-node[master]: Allow users to choose the SSH port

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Allow users to choose the SSH port
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/26631/2/src/ovirt/node/utils/security.py
File src/ovirt/node/utils/security.py:

Line 192:             except ValueError:
Line 193:                 raise RuntimeError("Port must be an integer")
Line 194:         if port is not None:
Line 195:             if int(port) in range(1, 65535):
Line 196:                 import ovirtnode.ovirtfunctions as ofunc
Please use the new codebase here, i think it is:
utils.fs.Config()
Line 197:                 self.logger.debug("Setting SSH port to %s" % port)
Line 198: 
Line 199:                 aug.set(augpath, port)
Line 200:                 ofunc.ovirt_store_config("/etc/ssh/sshd_config")


-- 
To view, visit http://gerrit.ovirt.org/26631
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb63ca2e2c59bd435c102c635a97ba3c9d4280af
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes