[node-patches] Change in ovirt-node[master]: Apply default disable on network details page

fabiand at fedoraproject.org fabiand at fedoraproject.org
Sun May 11 19:25:29 UTC 2014


Fabian Deutsch has posted comments on this change.

Change subject: Apply default disable on network details page
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

One inline question

http://gerrit.ovirt.org/#/c/27480/1/dracut/ovirt-cleanup.sh
File dracut/ovirt-cleanup.sh:

Line 172:                         fatal "Warning: '$ipv' is a member of a storage domain and may not be removed"
Line 173:                     exit 1
Line 174:                     fi
Line 175:                 done
Line 176:                 ipv_uuid = $(lvm pvs -o pv_uuid --noheading ${ipv})
Is there a bug related to the changes in this file?
Line 177:                 if [ $dev_uuid = $ipv_uuid ]; then
Line 178:                     # Multipath device showing up multiple times
Line 179:                     imach = 1
Line 180:                 fi


-- 
To view, visit http://gerrit.ovirt.org/27480
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I406f250e7cd2f3718d063826dcbe48cb1cbd57ef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list