[node-patches] Change in ovirt-node[master]: Clear BOOTIF at the end of a TUI install if it's set

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Clear BOOTIF at the end of a TUI install if it's set
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27485/1/src/ovirt/node/installer/core/progress_page.py
File src/ovirt/node/installer/core/progress_page.py:

Line 308:     class ClearBootif(utils.Transaction.Element):
Line 309:         title = "Removing BOOTIF during TUI install"
Line 310: 
Line 311:         def __init__(self):
Line 312:             File("/etc/default/ovirt").sed("/OVIRT_BOOTIF/d")
To be independent of the actual implementation or in this case the variable name (OVIRT_BOOTIF), please use the
config.defaults.Network().update(iface=None) - this call will just nuset the bootif but not touch any other network related arg.


Maybe it#s even cleare (from the code pov) to use: Network().configure_no_networking() - which makes it even "clearer".


-- 
To view, visit http://gerrit.ovirt.org/27485
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8483280ac36d5511931808a0bc8ee4bce91b32d3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes