[node-patches] Change in ovirt-node[master]: Add a confirmation page

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Add a confirmation page
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/27074/3/src/ovirt/node/installer/core/confirmation_page.py
File src/ovirt/node/installer/core/confirmation_page.py:

Line 38:         self._tagged_pvs = [x.split()[0] for x in
Line 39:                             process.check_output(["lvm", "vgs",
Line 40:                                                   "--noheadings",
Line 41:                                                   "-o", "pv_name_tags"]).split(
Line 42:                                 "\n") if "storage_domain" in x]
Please add a fallback for --dry mode and non-root testing.

And it seems as if lvm on F19 doesn't know the option (installer raises an exception):

$ sudo lvm vgs --noheadings -o pv_name_tags
...
  Unrecognised field: pv_name_tags
Line 43: 
Line 44:     def name(self):
Line 45:         return "Confirm disk selections"
Line 46: 


-- 
To view, visit http://gerrit.ovirt.org/27074
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0c099fbfbfda9bc609a024964905ee59e04280f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes