[node-patches] Change in ovirt-node[master]: Fix SNMP

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Fix SNMP
......................................................................


Patch Set 2: Code-Review-2

(1 comment)

Basically fine, but one issue.

http://gerrit.ovirt.org/#/c/27650/2/src/ovirt/node/setup/snmp/snmp_model.py
File src/ovirt/node/setup/snmp/snmp_model.py:

Line 109: 
Line 110:             def commit(self):
Line 111:                 if enabled and snmp_password:
Line 112:                     with open('/tmp/test', 'w') as f:
Line 113:                         f.write("%s\n" % snmp_password)
The two lines above should probably be dropped.
Line 114:                     enable_snmpd(snmp_password)
Line 115:                 else:
Line 116:                     disable_snmpd()
Line 117: 


-- 
To view, visit http://gerrit.ovirt.org/27650
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I488b99ea9308160420e3cf036fb8a6cced0f9196
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes