[node-patches] Change in ovirt-node[master]: Add a confirmation page

[hadong0720 at gmail.com]

hadong has posted comments on this change.

Change subject: Add a confirmation page
......................................................................


Patch Set 10:

Hey rbarry,

We should make sure list "LVM.VG(vg).tags" changed into a string before check "storage_domain" in it or not.

>>> "storage_domain" in " ".join([s.strip() for s in process.check_output(["lvm", "vgs", "--noheadings", "-o", "tags", "290a39a4-f0c3-4bb4-aba0-4002aaac1049"]).split("\n")])
True
>>> "storage_domain" in [s.strip() for s in process.check_output(["lvm", "vgs", "--noheadings", "-o", "tags", "290a39a4-f0c3-4bb4-aba0-4002aaac1049"]).split("\n")]
False

-- 
To view, visit http://gerrit.ovirt.org/27074
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0c099fbfbfda9bc609a024964905ee59e04280f
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No