[node-patches] Change in ovirt-node[master]: Fixing the virt who deamon starting https://bugzilla.redhat....

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Fixing the virt who deamon starting https://bugzilla.redhat.com/show_bug.cgi?id=1152947 Change-Id: Ia65a334e4fadbbb7ee6b6b7b066c356da147ee16 Signed-off-by: Tolik Litovsky <tlitovsk at redhat.com>
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Hey, thanks for this patch :)

I added some inline comments, and why did you remove the uinput dir under tests/?

http://gerrit.ovirt.org/#/c/34705/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-10-30 18:43:55 +0200
Line 4: Commit:     Tolik Litovsky <tlitovsk at redhat.com>
Line 5: CommitDate: 2014-10-31 21:37:39 +0200
Line 6: 
Line 7: Fixing the virt who deamon starting
Please add a new line after the the first line, and add some more details describing the initial problem, the cause, and the fix - and if you want further imnformations take a look here:

http://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#Commit-Guidelines
Line 8: https://bugzilla.redhat.com/show_bug.cgi?id=1152947
Line 9: Change-Id: Ia65a334e4fadbbb7ee6b6b7b066c356da147ee16


Line 4: Commit:     Tolik Litovsky <tlitovsk at redhat.com>
Line 5: CommitDate: 2014-10-31 21:37:39 +0200
Line 6: 
Line 7: Fixing the virt who deamon starting
Line 8: https://bugzilla.redhat.com/show_bug.cgi?id=1152947
For the bug url, please use the following format:

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1152947

This is a good habbit and is also picked up by the automation (to update the bugzilla bug, and attacht this patch to it.)
Line 9: Change-Id: Ia65a334e4fadbbb7ee6b6b7b066c356da147ee16


-- 
To view, visit http://gerrit.ovirt.org/34705
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia65a334e4fadbbb7ee6b6b7b066c356da147ee16
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <anatolylit at gmail.com>
Gerrit-Reviewer: Anatoly Litovsky <anatolylit at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes