[node-patches] Change in ovirt-node[master]: Log system() failures in ovirtfunctions

fabiand at redhat.com fabiand at redhat.com
Tue Nov 4 18:47:06 UTC 2014


Fabian Deutsch has submitted this change and it was merged.

Change subject: Log system() failures in ovirtfunctions
......................................................................


Log system() failures in ovirtfunctions

Don't just silently return False. Log stderr and the output if
the command fails, so we have some idea that it failed and why.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1158044
Change-Id: Icd1a8d425944c19e46e6189ae0983346d0154805
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirtnode/ovirtfunctions.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Fabian Deutsch: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd1a8d425944c19e46e6189ae0983346d0154805
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the node-patches mailing list