[node-patches] Change in ovirt-node[master]: Be more dynamic finding partitions for install

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Be more dynamic finding partitions for install
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

ing co

http://gerrit.ovirt.org/#/c/34603/1/src/ovirtnode/storage.py
File src/ovirtnode/storage.py:

Line 477:                 self.reread_partitions(_drv)
Line 478:             i = 15
Line 479:             while i > 0 and partpv is None:
Line 480:                 # e.g. /dev/cciss/c0d0p2
Line 481:                 for _partpv in [drv + hostvgpart, drv + "p" + hostvgpart
I guess a trailing coma (,) is missing.

Otherwise you concatenate the two strings.
Line 482:                                 drv + "-part" + hostvgpart]:
Line 483:                     if os.path.exists(_partpv):
Line 484:                         partpv = _partpv
Line 485:                         break


-- 
To view, visit http://gerrit.ovirt.org/34603
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eb95b0f30305b9b7184184d1106d5f037ebc363
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes