[node-patches] Change in ovirt-node[master]: Don't use utils.console.writeln() for the rescue shell

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Don't use utils.console.writeln() for the rescue shell
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/33342/1/src/ovirt/node/app.py
File src/ovirt/node/app.py:

Line 393: 
Line 394:         def open_console():
Line 395:             utils.process.call("clear ; echo \
Line 396:                                'Dropping to rescue shell...'; bash",
Line 397:                                shell=True)
I'd rather like to move the (one the left side) removed line down into the with self.ui.suspended(): block

Then we only write on the screen after the TUI has been suspended
Line 398: 
Line 399:         def return_ok(dialog, changes):
Line 400:             with self.ui.suspended():
Line 401:                 open_console()


-- 
To view, visit http://gerrit.ovirt.org/33342
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fa1de201481906a9b8eadbae962a65a8623e61
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes