[node-patches] Change in ovirt-node[master]: Reinstall will now overpower major version mismatch

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Reinstall will now overpower major version mismatch
......................................................................


Patch Set 3:

(2 comments)

Some inline commennts

http://gerrit.ovirt.org/#/c/35143/3/src/ovirt/node/installer/core/welcome_page.py
File src/ovirt/node/installer/core/welcome_page.py:

Line 98:             if is_installed and \
Line 99:                (media.version_major != installed.version_major):
Line 100:                 block_upgrade = True
Line 101: 
Line 102:         if utils.system.has_hostvg():
I beliege this if must stay an elif
Line 103:             has_hostvg = True
Line 104:             if os.path.exists("/dev/disk/by-label/ROOT"):
Line 105:                 block_upgrade = True
Line 106: 


http://gerrit.ovirt.org/#/c/35143/3/src/ovirt/node/utils/system.py
File src/ovirt/node/utils/system.py:

Line 130: def is_reinstall():
Line 131:     """is the system is in reinstalling mode
Line 132:     """
Line 133:     return any(arg in open("/proc/cmdline").read().split() for arg
Line 134:                in ["firstboot", "reinstall"])
we also need to cover reinstall=1 and firstboot=1
Line 135: 
Line 136: 
Line 137: def node_version():
Line 138:     """Return the version of the ovirt-node package


-- 
To view, visit http://gerrit.ovirt.org/35143
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I435113d4dcf69121e1956acc653344d1b052edb9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes