[node-patches] Change in ovirt-node[master]: Fix mount_boot for EL7

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Fix mount_boot for EL7
......................................................................


Patch Set 1:

(1 comment)

See inline comment

http://gerrit.ovirt.org/#/c/35058/1/scripts/ovirt-functions.in
File scripts/ovirt-functions.in:

Line 409: }
Line 410: 
Line 411: mount_boot() {
Line 412:     # Check if something other than tmpfs is at /boot
Line 413:     if grep -q -E " /boot [^tmpfs]" /etc/mtab; then
I think this regexp does not work: [^tmpfs] -- this matches any string starting with any char from "tmpfs".

I think we can use

    # if boot is tmpfs then mount Label=Boot else nothing
    if grep -q -E " /boot tmpfs" /etc/mtab; then continue ; else return 0 ; fi

And should mtab be used or rather proc/mounts?
Line 414:        return 0
Line 415:     fi
Line 416:     mkdir -p /boot
Line 417:     mount LABEL=Boot /boot


-- 
To view, visit http://gerrit.ovirt.org/35058
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I624b04162e40b114da006595713ef0b4a0958147
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes