[node-patches] Change in ovirt-node[node-3.0]: init: Split management_server if user used "addr:port"

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: init: Split management_server if user used "addr:port"
......................................................................


Patch Set 1:

(1 comment)

See my inline comments

http://gerrit.ovirt.org/#/c/33352/1/scripts/ovirt-init-functions.sh.in
File scripts/ovirt-init-functions.sh.in:

Line 889:                 echo "set /files$OVIRT_DEFAULTS/OVIRT_$PARAM '\"$value\"'" \
Line 890:                     >> $tmpaug
Line 891:             fi
Line 892:         fi
Line 893:     done
What about adding the logic here:

    if [[ "$management_server" == *:* ]]; then
        MSERVER=${management_server%:*}
        MPORT=${management_server#*:}
        echo "set /files$OVIRT_DEFAULTS/OVIRT_MANAGEMENT_SERVER '\"${MSERVER}\"'"  >> $tmpaug
        echo "set /files$OVIRT_DEFAULTS/OVIRT_MANAGEMENT_PORT '\"${MPORT}\"'" >> $tmpaug
    fi

Along these lines at least, this is untested.

The main reason is to get this special case out of the loop.
Line 894:     # block accidental bootif changes on upgrades
Line 895:     if [ "$upgrade" == "1" ]; then
Line 896:         sed -i '/OVIRT_BOOTIF/d' $tmpaug
Line 897:     fi


-- 
To view, visit http://gerrit.ovirt.org/33352
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b0d4055a8fd66c761a977d160422befc42019f9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: node-3.0
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes