[node-patches] Change in ovirt-node[master]: Reinstall will now overpower major version mismatch

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Reinstall will now overpower major version mismatch
......................................................................


Patch Set 7: Verified+1 Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/35143/7/src/ovirt/node/utils/system.py
File src/ovirt/node/utils/system.py:

Line 146: 
Line 147:     We are also conservative, if contradiction assume False:
Line 148: 
Line 149:     >>> is_reinstall("reinstall=1 firstboot=0 z")
Line 150:     False
> I think firstboot should get better naming may be.  But it for the future/
I fully agree.

There is also a related bug to unify the naming of our kernel arguments: https://bugzilla.redhat.com/show_bug.cgi?id=1025252
Line 151: 
Line 152:     >>> is_reinstall("foo bar z")
Line 153:     False
Line 154:     """


-- 
To view, visit http://gerrit.ovirt.org/35143
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I435113d4dcf69121e1956acc653344d1b052edb9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes