[node-patches] Change in ovirt-node[master]: Don't show basic video options in the boot menu

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Don't show basic video options in the boot menu
......................................................................


Patch Set 1:

(1 comment)

See my inline comments

http://gerrit.ovirt.org/#/c/35570/1/recipe/common-efi.ks
File recipe/common-efi.ks:

Line 12: hiddenmenu
Line 13: title Install / Upgrade ${PRODUCT_SHORT}-$VERSION-$RELEASE
Line 14:   kernel /isolinux/vmlinuz0 root=live:CDLABEL=$NAME rootfstype=auto ro liveimg check rootflags=ro crashkernel=128M elevator=deadline install rhgb quiet rd_NO_MULTIPATH rd_NO_LVM rd.luks=0 rd.md=0 rd.dm=0
Line 15:   initrd /isolinux/initrd0.img
Line 16: title Install / Upgrade with serial console ${PRODUCT_SHORT}-$VERSION-$RELEASE
Do we really need to remove the blocks ghere?

Ain't these blocks in this file used for el6?
Line 17:   kernel /isolinux/vmlinuz0 root=live:CDLABEL=$NAME rootfstype=auto ro liveimg check rootflags=ro crashkernel=128M elevator=deadline install rhgb quiet rd_NO_MULTIPATH rd_NO_LVM rd.luks=0 rd.md=0 rd.dm=0  console=ttyS0,115200n8
Line 18:   initrd /isolinux/initrd0.img
Line 19: title Reinstall ${PRODUCT_SHORT}-$VERSION-$RELEASE
Line 20:   kernel /isolinux/vmlinuz0 root=live:CDLABEL=$NAME rootfstype=auto ro liveimg check rootflags=ro crashkernel=128M elevator=deadline install rhgb quiet rd_NO_MULTIPATH rd_NO_LVM rd.luks=0 rd.md=0 rd.dm=0  reinstall


-- 
To view, visit http://gerrit.ovirt.org/35570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbaf4d96849c70b2b9b115bad29365b72947744b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes