[node-patches] Change in ovirt-node[master]: firewall: Use correct logic if firewalld is used

[fabiand at redhat.com]

Fabian Deutsch has submitted this change and it was merged.

Change subject: firewall: Use correct logic if firewalld is used
......................................................................


firewall: Use correct logic if firewalld is used

Previously the decision if firewealld should be used or not was lax, it
was only based on the fact that firewalld was used.
Now the decision is made on the install state and service state of
firewalld.

Now firewalld will only be configured if it's installed and the service
running, otherwise iptables will be used.

Change-Id: Ica13f63ac67d0ba1dd29f5b1566e96036e78eefc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1150328
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/utils/firewall.py
1 file changed, 20 insertions(+), 9 deletions(-)

Approvals:
  Fabian Deutsch: Verified; Looks good to me, approved
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/33938
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ica13f63ac67d0ba1dd29f5b1566e96036e78eefc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server