[node-patches] Change in ovirt-node[node-3.0]: functions: Yet another fix for retnum persistence

fabiand at redhat.com fabiand at redhat.com
Wed Oct 22 05:05:38 UTC 2014


Fabian Deutsch has submitted this change and it was merged.

Change subject: functions: Yet another fix for retnum persistence
......................................................................


functions: Yet another fix for retnum persistence

There were two cases in which the new retnum variant of persist fails:

1. config file is still bind mounted
2. If everything goes well, then the function returned True
   which got interpreted as a return value of 1.

The target config file is now always unmounted, before a mount is tried,
and the return True  on success got removed.

Change-Id: I2caeea64c79bb55a614cd363082d70afcdd20501
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120650
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M scripts/ovirt-functions.in
M scripts/ovirt-init-functions.sh.in
M src/ovirtnode/ovirtfunctions.py
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Fabian Deutsch: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2caeea64c79bb55a614cd363082d70afcdd20501
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: node-3.0
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the node-patches mailing list