[node-patches] Change in ovirt-node-iso[master]: adding an option to throw in a additional recepie. Such rec...

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: adding an option to throw in a additional recepie.  Such recepie may include extra repos for example
......................................................................


Patch Set 1:

(2 comments)

Nifty idea and solution! Just some small things

http://gerrit.ovirt.org/#/c/34471/1/Makefile.am
File Makefile.am:

Line 189: 	    echo "VERSION=$(VERSION)" ;\
Line 190: 	    echo "RELEASE=$(RELEASE)" ;\
Line 191: 	) > $@
Line 192: if USE_EXTRA_RECIPE
Line 193: 	echo "%include $(EXTRA_RECIPE)" >> $(NAME0).ks 
As above.

Maybe also use:

    echo -e "\n%include $(EXTRA_RECIPE)" >> $(NAME0).ks"

In case that $(NAME0).ks ends without  newline
Line 194: endif
Line 195: 	ksflatten -c $(NAME0).ks -o $(PACKAGE).ks
Line 196: 
Line 197: $(PACKAGE).$(PKG_FMT) iso: kickstarts version.ks repos.ks


http://gerrit.ovirt.org/#/c/34471/1/configure.ac
File configure.ac:

Line 35:             [Specify extra recipe to be used .  Defaults to none])],
Line 36:             [EXTRA_RECIPE="$withval" 
Line 37:             use_extra_recipe=true],
Line 38:             [EXTRA_RECIPE="false"])
Line 39: AC_SUBST([EXTRA_RECIPE])          
Please remove the trailing whitespaces here and above
Line 40: AM_CONDITIONAL([USE_EXTRA_RECIPE],[test x$use_extra_recipe = xtrue])
Line 41: 
Line 42: 
Line 43: PACKAGE_NAME=ovirt-node-iso


-- 
To view, visit http://gerrit.ovirt.org/34471
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I235ed048855a7f44ee9070142799f4316f1cb595
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-iso
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <anatolylit at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes