[node-patches] Change in ovirt-node[master]: Log system() failures in ovirtfunctions

rbarry at redhat.com rbarry at redhat.com
Tue Oct 28 14:25:39 UTC 2014


Ryan Barry has uploaded a new change for review.

Change subject: Log system() failures in ovirtfunctions
......................................................................

Log system() failures in ovirtfunctions

Don't just silently return False

Change-Id: Icd1a8d425944c19e46e6189ae0983346d0154805
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirtnode/ovirtfunctions.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/61/34561/1

diff --git a/src/ovirtnode/ovirtfunctions.py b/src/ovirtnode/ovirtfunctions.py
index be828a3..d02c3c0 100644
--- a/src/ovirtnode/ovirtfunctions.py
+++ b/src/ovirtnode/ovirtfunctions.py
@@ -1545,6 +1545,7 @@
     if system_cmd.returncode == 0:
         return True
     else:
+        logger.debug("Command failed: %s" % err)
         return False
 
 def password_check(password_1, password_2, min_length=1):


-- 
To view, visit http://gerrit.ovirt.org/34561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd1a8d425944c19e46e6189ae0983346d0154805
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>



More information about the node-patches mailing list