[node-patches] Change in ovirt-node[master]: umount partitions before mounting them

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: umount partitions before mounting them
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/34611/2/src/ovirtnode/install.py
File src/ovirtnode/install.py:

Line 471:             if not _functions.system(e2label_cmd):
Line 472:                 logger.error("Failed to label new Root partition")
Line 473:                 return False
Line 474:         _functions.system("umount -l %s" % candidate_dev)
Line 475:         _functions.system("umount -l /liveos")
hey Ryan, just question: what about check the value of the above system calls? If the above umounts return False? Shouldn't we return False immediately?
Line 476:         mount_cmd = "mount \"%s\" /liveos" % candidate_dev
Line 477:         if not _functions.system(mount_cmd):
Line 478:             logger.error("Failed to mount %s on /liveos" % candidate_dev)
Line 479:             _functions.system("lsof")


-- 
To view, visit http://gerrit.ovirt.org/34611
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb87ee4153842e90472508f0fa6594f204e84268
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes