[node-patches] Change in ovirt-node[master]: network: use iproute instead of vconfig

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: network: use iproute instead of vconfig
......................................................................


Patch Set 1:

Fabian/Ryan, is it jenkins network failure?

4:44:30 **********************************************************************
04:44:30 File "/home/jenkins/workspace/ovirt-node_master_check-local_gerrit/src/ovirt/node/utils/network.py", line 246, in ovirt.node.utils.network.NIC.has_link
04:44:30 Failed example:
04:44:30     NIC("lo").has_link()
04:44:30 Exception raised:
04:44:30     Traceback (most recent call last):
04:44:30       File "/usr/lib64/python2.6/doctest.py", line 1253, in __run
04:44:30         compileflags, 1) in test.globs
04:44:30       File "<doctest ovirt.node.utils.network.NIC.has_link[0]>", line 1, in <module>
04:44:30         NIC("lo").has_link()
04:44:30       File "/home/jenkins/workspace/ovirt-node_master_check-local_gerrit/src/ovirt/node/utils/network.py", line 268, in has_link
04:44:30         process.call(["ip", "link", "set", "dev", self.ifname, "up"])
04:44:30       File "/home/jenkins/workspace/ovirt-node_master_check-local_gerrit/src/ovirt/node/utils/process.py", line 130, in call
04:44:30         return int(subprocess.call(*args, **kwargs))
04:44:30       File "/usr/lib64/python2.6/subprocess.py", line 478, in call
04:44:30         p = Popen(*popenargs, **kwargs)
04:44:30       File "/usr/lib64/python2.6/subprocess.py", line 642, in __init__
04:44:30         errread, errwrite)
04:44:30       File "/usr/lib64/python2.6/subprocess.py", line 1234, in _execute_child
04:44:30         raise child_exception
04:44:30     OSError: [Errno 2] No such file or directory
04:44:30 **********************************************************************
04:44:30 1 items had failures:
04:44:30    1 of   1 in ovirt.node.utils.network.NIC.has_link
04:44:30 ***Test Failed*** 1 failures.
04:44:30 Failures from ovirt.node.utils.network: 1
04:44:30 make: *** [ovirt/node/utils/network.py.doctest] Error 255
04:44:30 Build step 'Execute shell' marked build as failure
04:44:31 Recording test results

-- 
To view, visit http://gerrit.ovirt.org/32341
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73e74c3c90ce28ff88cc1a80dc41f79121932b1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No