[node-patches] Change in ovirt-node[master]: hooks: Add 01-sanlock-check into on-changed-boot-image

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: hooks: Add 01-sanlock-check into on-changed-boot-image
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

-1 as I have a question

http://gerrit.ovirt.org/#/c/32659/1/scripts/ovirt-init-functions.sh.in
File scripts/ovirt-init-functions.sh.in:

Line 1024:         do
Line 1025:             log "Running handler: $handler"
Line 1026:             "$handler" >> $OVIRT_LOGFILE 2>&1
Line 1027:         done
Line 1028:     fi
Hi hadong, thanks for your patch. 
Not sure if I understood the above idea, isn't a duplicate code?
What about to include this sanlock user creation script into ovirt-node-plugin-vdsm as vdsm requires sanlock in the spec?
Line 1029: 
Line 1030:     return 0
Line 1031: }
Line 1032: 


-- 
To view, visit http://gerrit.ovirt.org/32659
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I441ed24f4488e67d9b06be670499526960700c4a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes