[node-patches] Change in ovirt-node[master]: edit-node: _setup_pki_entitlement() call missed communicate()

dougsland at redhat.com dougsland at redhat.com
Tue Sep 9 07:34:37 UTC 2014


Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: edit-node: _setup_pki_entitlement() call missed communicate()
......................................................................

edit-node: _setup_pki_entitlement() call missed communicate()

To create the self._instroot/etc/pki/entitlement before the mount bind
we should call communicate().

Change-Id: Ieb8fbc8ea81f15f94e227ef043f3699bc0f05b5b
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
---
M tools/edit-node
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/68/32668/1

diff --git a/tools/edit-node b/tools/edit-node
index 220a9fa..db5f965 100755
--- a/tools/edit-node
+++ b/tools/edit-node
@@ -954,6 +954,7 @@
         if os.path.exists("/etc/pki/entitlement"):
             cmd = "mkdir -p %s/etc/pki/entitlement" % self._instroot
             f = subprocess.Popen(cmd, shell=True, stdout=PIPE, stderr=STDOUT)
+            output, err = f.communicate()
             cmd = "mount -o bind %s %s/etc/pki/entitlement" % \
                 ("/etc/pki/entitlement", self._instroot)
             f = subprocess.Popen(cmd, shell=True, stdout=PIPE,


-- 
To view, visit http://gerrit.ovirt.org/32668
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb8fbc8ea81f15f94e227ef043f3699bc0f05b5b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>



More information about the node-patches mailing list