[node-patches] Change in ovirt-node[master]: utils: Use firewall.open_port

[fabiand at redhat.com]

Fabian Deutsch has uploaded a new change for review.

Change subject: utils: Use firewall.open_port
......................................................................

utils: Use firewall.open_port

Change-Id: Ia2bca398c09dc0f4d451ea1f201f2035cf9f2a3b
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/config/defaults.py
M src/ovirt/node/setup/snmp/snmp_model.py
2 files changed, 2 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/22/32822/1

diff --git a/src/ovirt/node/config/defaults.py b/src/ovirt/node/config/defaults.py
index b16a535..64d7e6b 100644
--- a/src/ovirt/node/config/defaults.py
+++ b/src/ovirt/node/config/defaults.py
@@ -1598,10 +1598,7 @@
 
             def commit(self):
                 ssh.port(port)
-                if firewall.is_firewalld():
-                    firewall.setup_firewalld(port, "tcp")
-                else:
-                    firewall.setup_iptables(port, "tcp")
+                firewall.open_port(port, "tcp")
 
         class ConfigureStrongRNG(utils.Transaction.Element):
             title = "Configuring SSH strong RNG"
diff --git a/src/ovirt/node/setup/snmp/snmp_model.py b/src/ovirt/node/setup/snmp/snmp_model.py
index 92f2d56..50639ce 100644
--- a/src/ovirt/node/setup/snmp/snmp_model.py
+++ b/src/ovirt/node/setup/snmp/snmp_model.py
@@ -61,10 +61,7 @@
     system.service("snmpd", "start")
     fs.Config().persist(snmp_conf)
 
-    if firewall.is_firewalld():
-        firewall.setup_firewalld(port="161", proto="udp")
-    else:
-        firewall.setup_iptables(port="161", proto="udp")
+    firewall.open_port(port="161", proto="udp")
 
 
 def disable_snmpd():


-- 
To view, visit http://gerrit.ovirt.org/32822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2bca398c09dc0f4d451ea1f201f2035cf9f2a3b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>