[node-patches] Change in ovirt-node[master]: Drop the MAC from the network page

[rbarry at redhat.com]

Ryan Barry has uploaded a new change for review.

Change subject: Drop the MAC from the network page
......................................................................

Drop the MAC from the network page

So we can show full interface names on EL7 regardless of whether
it's managed or not, drop the MAC address from the NICTable. It's
available from the details dialog anyway. Show ifname, status, and
vendor only.

Change-Id: I7358fd2d479b0d257a4558514f4ead680eed4b19
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128072
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/setup/core/network_page.py
1 file changed, 4 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/45/33345/1

diff --git a/src/ovirt/node/setup/core/network_page.py b/src/ovirt/node/setup/core/network_page.py
index d3b25fd..8b5b8f5 100644
--- a/src/ovirt/node/setup/core/network_page.py
+++ b/src/ovirt/node/setup/core/network_page.py
@@ -41,10 +41,7 @@
 
 class NicTable(ui.Table):
     def __init__(self, path, height=3, multi=False, filter_configured=False):
-        if not has_managed_ifnames():
-            header = "Device  Status       Model         MAC Address"
-        else:
-            header = "Device          Status       MAC Address      "
+        header = "Device          Status       Model            "
         if multi:
             header = "    " + header
 
@@ -72,15 +69,10 @@
                 is_cfg = ("Configured" if nic.is_configured() else
                           "Unconfigured")
 
-            fields = [justify(nic.ifname, 7),
-                      justify(is_cfg, 12)]
+            fields = [justify(nic.ifname, 15),
+                      justify(is_cfg, 12),
+                      justify(nic.vendor, 22)]
 
-            if has_managed_ifnames():
-                fields[0] = justify(nic.ifname, 15)
-            if not has_managed_ifnames():
-                fields.append(justify(nic.vendor, 13))
-
-            fields.append(justify(nic.hwaddr, 17))
             description = " ".join(fields)
 
             node_nics.append((name, description))


-- 
To view, visit http://gerrit.ovirt.org/33345
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7358fd2d479b0d257a4558514f4ead680eed4b19
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>