[node-patches] Change in ovirt-node[master]: Don't use lvmetad

[nsoffer at redhat.com]

Nir Soffer has posted comments on this change.

Change subject: Don't use lvmetad
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.ovirt.org/#/c/33540/5/recipe/rhevh7-post.ks
File recipe/rhevh7-post.ks:

Line 6: dirs    /var/db
Line 7: EOF_RWTAB_RHEVH
Line 8: 
Line 9: # disable lvmetad rhbz#1147217
Line 10: sed -ie 's/^[^#]\( *\)lvm_metad *=.*/\1lvm_metad = 1/' /etc/lvm/lvm.conf
This will *enable* use_lvmetad instead of disabling?!

Also I think this pattern would be better, allowing any whitespace, or indentation, and not repeating data:

    sed -ie 's/^\(\s*use_lvmetad\)\s*=\s*1/\1 = 0/' /etc/lvm/lvm.conf
Line 11: grep -E '^[^#]\s*use_lvmetad = 1/' /etc/lvm/lvm.conf || echo "lvmetad not disabled, value is:" && \
Line 12:     grep -E '^[^#]use_lvmetad\s*=' /etc/lvm/lvm.conf
Line 13: 
Line 14: systemctl disable lvm2-lvmetad


Line 8: 
Line 9: # disable lvmetad rhbz#1147217
Line 10: sed -ie 's/^[^#]\( *\)lvm_metad *=.*/\1lvm_metad = 1/' /etc/lvm/lvm.conf
Line 11: grep -E '^[^#]\s*use_lvmetad = 1/' /etc/lvm/lvm.conf || echo "lvmetad not disabled, value is:" && \
Line 12:     grep -E '^[^#]use_lvmetad\s*=' /etc/lvm/lvm.conf
This would be more little cleaner:

     enabled=$(grep -E ^\s*use_lvmetad\s*=\s*1' /etc/lvm/lvm.conf)
     if [ -n "$enabled" ]; then
         complain and fail...
     fi
Line 13: 
Line 14: systemctl disable lvm2-lvmetad
Line 15: systemctl disable lvm2-lvmetad.socket
Line 16: 


-- 
To view, visit http://gerrit.ovirt.org/33540
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie111f462d15bde004506638e3d70943e3dd9daba
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes