[node-patches] Change in ovirt-node-iso[master]: Adding virt preview repo for fc20 Switching to use of ovirt-...

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Adding virt preview repo for fc20 Switching to use of ovirt-node-vdsm recepie Allowing to select the main kickstart for use with local builds of ovirt node
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/39441/2/Makefile.am
File Makefile.am:

Line 15: # MA  02110-1301, USA.  A copy of the GNU General Public License is
Line 16: # also available at http://www.gnu.org/copyleft/gpl.html.
Line 17: 
Line 18: PACKAGE           = @PACKAGE_NAME@
Line 19: NAME0			  = @MAIN_KS@
please use use spaces instead of tabs, here and further down
Line 20: RECIPE            = $(PACKAGE).ks
Line 21: PRODUCT           = @PRODUCT_NAME@
Line 22: EXTRA_RECIPE      = @EXTRA_RECIPE@
Line 23: PRODUCT_SHORT     ?= $(PRODUCT)


https://gerrit.ovirt.org/#/c/39441/2/configure.ac
File configure.ac:

Line 37: AC_ARG_WITH([kickstart], [AC_HELP_STRING([--with-kickstart],
Line 38:             [Specify a kickstart file to use.  Defaults to vdsm-plugin-iso.ks])],
Line 39:             [MAIN_KS="$withval"],
Line 40:             [MAIN_KS=vdsm-plugin-iso.ks])
Line 41: AC_SUBST([MAIN_KS])
We should somehow make this option mandatory
Line 42: 
Line 43: AC_ARG_WITH([build_number], [AC_HELP_STRING([--with-build-number],
Line 44:             [Specify a build number.])],
Line 45:             [BUILD_NUMBER="$withval"],


-- 
To view, visit https://gerrit.ovirt.org/39441
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3db401c1fb97ad013d94d24bc0c6aa4431e8d2eb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node-iso
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes